Discussion:
[jruby-dev] "library" directory of ruby spec gone?
(too old to reply)
Uwe Kubosch
2014-07-18 10:14:04 UTC
Permalink
Hi all!

I am trying to look at https://github.com/jruby/jruby/issues/1824 , and as we should, I started by ensuring we had green tests and then to locate the tests for YAML.load_file.

I was unable to get green tests, but that is another story.

I found “test/jruby/test_yaml.rb” that was not included in “test/jruby.index” and has not been run for a while, and it failed as expected of stale tests.

Then I thought that this should be covered by RubySpec, and I started looking in the rubyspec/rubyspec GitHub repository. I can find good tests for yaml in the “1.x” branch of ruby spec in https://github.com/rubyspec/rubyspec/blob/1.x/library/yaml/load_file_spec.rb , but the top level “library” directory is gone from rubyspec master.

Anyone know where it has gone?

I guess that is the reason this has not been tested on JRuby master, right?

Any help or information is appreciated.

--
Uwe Kubosch
uwe-***@public.gmane.org
http://kubosch.no/





---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email
Thomas E Enebo
2014-07-18 15:49:57 UTC
Permalink
Brian split out all the libraries to over 100 separate rubysl-* gems and
the tests are in each one. So you need to retrieve tests from the
appropriate gem to run specs now. They are no longer part of rubyspec.

-Tom
Post by Uwe Kubosch
Hi all!
I am trying to look at https://github.com/jruby/jruby/issues/1824 , and
as we should, I started by ensuring we had green tests and then to locate
the tests for YAML.load_file.
I was unable to get green tests, but that is another story.
I found “test/jruby/test_yaml.rb” that was not included in
“test/jruby.index” and has not been run for a while, and it failed as
expected of stale tests.
Then I thought that this should be covered by RubySpec, and I started
looking in the rubyspec/rubyspec GitHub repository. I can find good tests
for yaml in the “1.x” branch of ruby spec in
https://github.com/rubyspec/rubyspec/blob/1.x/library/yaml/load_file_spec.rb
, but the top level “library” directory is gone from rubyspec master.
Anyone know where it has gone?
I guess that is the reason this has not been tested on JRuby master, right?
Any help or information is appreciated.
--
Uwe Kubosch
http://kubosch.no/
---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email
--
blog: http://blog.enebo.com twitter: tom_enebo
mail: tom.enebo-***@public.gmane.org
Uwe Kubosch
2014-07-18 19:30:06 UTC
Permalink
Thanks, Tom! Found it!

How are we going to handle this? We need to run these tests to ensure JRuby is compliant, right?
Brian split out all the libraries to over 100 separate rubysl-* gems and the tests are in each one. So you need to retrieve tests from the appropriate gem to run specs now. They are no longer part of rubyspec.
-Tom
Hi all!
I am trying to look at https://github.com/jruby/jruby/issues/1824 , and as we should, I started by ensuring we had green tests and then to locate the tests for YAML.load_file.
I was unable to get green tests, but that is another story.
I found “test/jruby/test_yaml.rb” that was not included in “test/jruby.index” and has not been run for a while, and it failed as expected of stale tests.
Then I thought that this should be covered by RubySpec, and I started looking in the rubyspec/rubyspec GitHub repository. I can find good tests for yaml in the “1.x” branch of ruby spec in https://github.com/rubyspec/rubyspec/blob/1.x/library/yaml/load_file_spec.rb , but the top level “library” directory is gone from rubyspec master.
Anyone know where it has gone?
I guess that is the reason this has not been tested on JRuby master, right?
Any help or information is appreciated.
--
Uwe Kubosch
http://kubosch.no/
---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email
--
blog: http://blog.enebo.com twitter: tom_enebo
--
Uwe Kubosch
uwe-***@public.gmane.org
http://kubosch.no/





---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email
Thomas E Enebo
2014-07-18 22:35:53 UTC
Permalink
I don't know how we solve this. That is a ton of repos to extract specs
from. We could make a script I guess?

-Tom
Post by Uwe Kubosch
Thanks, Tom! Found it!
How are we going to handle this? We need to run these tests to ensure
JRuby is compliant, right?
Post by Thomas E Enebo
Brian split out all the libraries to over 100 separate rubysl-* gems and
the tests are in each one. So you need to retrieve tests from the
appropriate gem to run specs now. They are no longer part of rubyspec.
Post by Thomas E Enebo
-Tom
Hi all!
I am trying to look at https://github.com/jruby/jruby/issues/1824 , and
as we should, I started by ensuring we had green tests and then to locate
the tests for YAML.load_file.
Post by Thomas E Enebo
I was unable to get green tests, but that is another story.
I found “test/jruby/test_yaml.rb” that was not included in
“test/jruby.index” and has not been run for a while, and it failed as
expected of stale tests.
Post by Thomas E Enebo
Then I thought that this should be covered by RubySpec, and I started
looking in the rubyspec/rubyspec GitHub repository. I can find good tests
for yaml in the “1.x” branch of ruby spec in
https://github.com/rubyspec/rubyspec/blob/1.x/library/yaml/load_file_spec.rb
, but the top level “library” directory is gone from rubyspec master.
Post by Thomas E Enebo
Anyone know where it has gone?
I guess that is the reason this has not been tested on JRuby master,
right?
Post by Thomas E Enebo
Any help or information is appreciated.
--
Uwe Kubosch
http://kubosch.no/
---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email
--
blog: http://blog.enebo.com twitter: tom_enebo
--
Uwe Kubosch
http://kubosch.no/
---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email
--
blog: http://blog.enebo.com twitter: tom_enebo
mail: tom.enebo-***@public.gmane.org
Loading...